Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing NULL in x509 RSA certs #39

Closed
arekinath opened this issue Dec 5, 2017 · 1 comment
Closed

Missing NULL in x509 RSA certs #39

arekinath opened this issue Dec 5, 2017 · 1 comment

Comments

@arekinath
Copy link
Contributor

x509 RSA certs should have a NULL after the algorithm OID for backwards compat reasons. The output we're producing is valid but may be unparseable by some ancient certificate parsers -- and also, it means we can produce mismatched output when signing some certificates.
joyent-automation pushed a commit that referenced this issue Dec 14, 2017
@arekinath
#39 Missing NULL in x509 RSA certs
4d01aed 
Reviewed by: Cody Peter Mello <cody.mello@joyent.com>
Approved by: Cody Peter Mello <cody.mello@joyent.com>
@roccomuso
Copy link

+1 thanks

This was referenced Oct 10, 2018
Merged
Merged
@dependabot-preview dependabot-preview bot mentioned this issue Dec 30, 2018
Closed
This was referenced Apr 12, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced May 31, 2019
Merged
Open
Closed
Merged
@dependabot dependabot bot mentioned this issue Jul 12, 2019
Merged
@dependabot-preview dependabot-preview bot mentioned this issue Jul 19, 2019
Closed
@dependabot dependabot bot mentioned this issue Aug 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arekinath @roccomuso