Fix a goroutine leak in the signal handler code path #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the |
The root cause of this issue was regarding our change to shutting down via context. While implementating that change set there was a goroutine leak introduced that did not provide a clean way for shutting down and reloading the signal handler. This caused signal handling to be duplicated across reloads. Fixes: TritonDataCenter#521
|
I'm optimizing this a bit further now that I've noticed we no longer need this in the main application event loop. |
|
I think this one is GTG @stack72. |
|
LGTM - we discussed this outside of github already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of this issue was regarding our change to shutting down via
context. While implementating that change set there was a goroutine leak
introduced that did not provide a clean way for shutting down and reloading the
signal handler. This caused signal handling to be duplicated across reloads.
Fixes: #521