Avoid racing reparent in zombie-reaping integration test #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At any given time we may have up to 1 zombie parented to PID1 (it has been reparented but not yet reaped) and 1 zombie not yet parented to PID1. We can't test any more precisely than this without racing the kernel reparenting mechanism (`do_exit()`). Also updated the test to capture the ps tree only once so that we don't log something different from what we tested.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At any given time we may have up to 1 zombie parented to PID1 (it has been reparented but not yet reaped) and 1 zombie not yet parented to PID1. We can't test any more precisely than this without racing the kernel reparenting mechanism (
do_exit()).Also updated the test to capture the ps tree only once so that we don't log something different from what we tested.
cc @justenwalker per our discussion in #119