Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@universal/ng-aspnetcore-engine usage in boot.server.ts #430

Closed
jrmcdona opened this issue Oct 4, 2017 · 1 comment
Closed

@universal/ng-aspnetcore-engine usage in boot.server.ts #430

jrmcdona opened this issue Oct 4, 2017 · 1 comment

Comments

@jrmcdona
Copy link
Contributor

jrmcdona commented Oct 4, 2017

Hello-

Any reason why boot.server.ts. doesn't use @universal/ng-aspnetcore-engine?
// Temporary * the engine will be on npm soon (@universal/ng-aspnetcore-engine)

I see it is installed in package.json.

The documentation says to reference this app:
https://www.npmjs.com/package/@nguniversal/aspnetcore-engine

I assume just lack of time and/or nobody PR'd it. But wanted to double check if it is stable.

Thanks

@MarkPieszak
Copy link
Member

MarkPieszak commented Oct 10, 2017

It'll be adding in the upcoming 5.0 release (as it's waiting to be merged in there, there were many updates for 5.0)

5.0 PR here:
#437

Universal aspnetcore-engine PR here:
angular/universal#825

MarkPieszak added a commit that referenced this issue Nov 2, 2017
* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes #434
Closes #435
Closes #430
Closes #424
BillSheldon-HunterIndustries pushed a commit to BillSheldon-HunterIndustries/aspnetcore-angular2-universal that referenced this issue Jan 17, 2018
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
BillSheldon-HunterIndustries pushed a commit to BillSheldon-HunterIndustries/aspnetcore-angular2-universal that referenced this issue May 15, 2018
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
BillSheldon-HunterIndustries pushed a commit to BillSheldon-HunterIndustries/aspnetcore-angular2-universal that referenced this issue May 15, 2018
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
BillSheldon-HunterIndustries pushed a commit to Hunter-Industries/aspnetcore-angular2-universal that referenced this issue May 16, 2018
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
BillSheldon-HunterIndustries pushed a commit to BillSheldon-HunterIndustries/aspnetcore-angular2-universal that referenced this issue Jun 8, 2018
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
BillSheldon-HunterIndustries pushed a commit to BillSheldon-HunterIndustries/aspnetcore-angular2-universal that referenced this issue Jun 8, 2018
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
BillSheldon-HunterIndustries pushed a commit to BillSheldon-HunterIndustries/aspnetcore-angular2-universal that referenced this issue Jun 8, 2018
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
BillSheldon-HunterIndustries pushed a commit to BillSheldon-HunterIndustries/aspnetcore-angular2-universal that referenced this issue Jun 8, 2018
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants