Docker Storage Support for the Firmware Manager #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmccoystephenson
requested review from
payneBrandon,
richardlsmith and
mwodahl
| @@ -40,7 +40,7 @@ Available REST endpoints: | |||
|
|
|||
| To properly run the firmware_manager microservice the following services are also required: | |||
|
|
|||
| - Cloud based blob storage | |||
| - Cloud based blob storage (if not using a directory mounted as a docker volume) | |||
There was a problem hiding this comment.
This is a bit confusing, should the Docker volume be organized the same?
There was a problem hiding this comment.
Yes it should. This has been modified to improve clarity.
payneBrandon
requested changes
Feb 13, 2024
|
This PR is ready for re-review. @payneBrandon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Firmware Manager addon currently only supports storing firmware files in GCP. In a deployment where this isn't desired, we need another way to store the firmware files.
Solution
Support for storing firmware files in a directory mounted as a docker volume has been added to the project.
Testing