add better exception handling

TrickfireRobotics · Dec 21, 2024 · 44b2537 · 44b2537
1 parent 11cadbb
commit 44b2537
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 13 deletions.
diff --git a/TrickFireDiscordBot/Program.cs b/TrickFireDiscordBot/Program.cs
@@ -27,7 +27,7 @@ private static async Task Main(string[] args)
             await Task.Delay(-1);
             return;
         }
-
+        
         ILogger logger = host.Services.GetRequiredService<ILogger<Program>>();
 
         try
@@ -73,6 +73,8 @@ private static IHost CreateHost(string baseDir, string[] secrets)
         builder.Configuration["BOT_TOKEN"] = secrets[0];
         builder.Configuration["NOTION_SECRET"] = secrets[1];
 
+        builder.Services.ConfigureTypeSection<HostOptions>(builder.Configuration);
+
         // Get all types
         Assembly asm = Assembly.GetExecutingAssembly();
         foreach (Type type in asm.GetTypes())

diff --git a/TrickFireDiscordBot/Services/RoleSyncer.cs b/TrickFireDiscordBot/Services/RoleSyncer.cs
@@ -118,7 +118,14 @@ protected override async Task ExecuteAsync(CancellationToken stoppingToken)
     {
         while (!stoppingToken.IsCancellationRequested)
         {
-            await SyncRoles(await _pageQueue.Reader.ReadAsync(stoppingToken));
+            try
+            {
+                await SyncRoles(await _pageQueue.Reader.ReadAsync(stoppingToken));
+            }
+            catch (Exception ex)
+            {
+                Logger.LogError(ex, "Error in RoleSyncer main loop: ");
+            }
         }
     }
 

diff --git a/TrickFireDiscordBot/Services/WebhookListener.cs b/TrickFireDiscordBot/Services/WebhookListener.cs
@@ -41,17 +41,24 @@ protected override async Task ExecuteAsync(CancellationToken stoppingToken)
     {
         while (!stoppingToken.IsCancellationRequested)
         {
-            // Wait for request
-            HttpListenerContext ctx;
-            ctx = await _listener.GetContextAsync().WaitAsync(stoppingToken);
-
-            // Read request body
-            OnWebhookReceived?.Invoke(ctx.Request);
-
-            // Return ok response on request
-            ctx.Response.StatusCode = (int)HttpStatusCode.OK;
-            ctx.Response.OutputStream.Write(Encoding.UTF8.GetBytes("Ok"));
-            ctx.Response.OutputStream.Close();
+            try
+            {
+                // Wait for request
+                HttpListenerContext ctx;
+                ctx = await _listener.GetContextAsync().WaitAsync(stoppingToken);
+
+                // Read request body
+                OnWebhookReceived?.Invoke(ctx.Request);
+
+                // Return ok response on request
+                ctx.Response.StatusCode = (int)HttpStatusCode.OK;
+                ctx.Response.OutputStream.Write(Encoding.UTF8.GetBytes("Ok"));
+                ctx.Response.OutputStream.Close();
+            }
+            catch (Exception ex) 
+            {
+                Logger.LogError(ex, "Exception in WebhookListener main loop: ");
+            }
         }
     }
 

diff --git a/TrickFireDiscordBot/config.json b/TrickFireDiscordBot/config.json
@@ -18,5 +18,8 @@
   },
   "BotStateOptions": {
     "FileLocation": "state.json"
+  },
+  "HostOptions": {
+    "BackgroundServiceExceptionBehavior": "Ignore"
   }
 }