fix role assignment

TrickfireRobotics · Dec 19, 2024 · 2187b3e · 2187b3e
1 parent 1dd90c0
commit 2187b3e
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/TrickFireDiscordBot/RoleSyncer.cs b/TrickFireDiscordBot/RoleSyncer.cs
@@ -115,15 +115,10 @@ private void OnWebhook(HttpListenerRequest request)
                 return null;
             }
 
-            IEnumerable<DiscordRole?> newRoles = await GetRoles(notionPage);
+            IEnumerable<DiscordRole> newRoles = await GetRoles(notionPage);
             Logger.LogInformation(member.DisplayName);
-            foreach (DiscordRole? role in newRoles)
+            foreach (DiscordRole role in newRoles)
             {
-                if (role is null)
-                {
-                    continue;
-                }
-
                 Logger.LogInformation(role!.Name);
             }
 
@@ -133,7 +128,7 @@ private void OnWebhook(HttpListenerRequest request)
                 int highestRole = botMember.Roles.Max(role => role.Position);
                 await member.ModifyAsync(model =>
                 {
-                    List<DiscordRole> rolesWithLeadership = [];
+                    List<DiscordRole> rolesWithLeadership = new(newRoles);
                     foreach (DiscordRole role in member.Roles.Where(role => role.Position >= highestRole))
                     {
                         rolesWithLeadership.Add(role);