Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close database connections after exiting from the db_session to avoid access violation on Python 3.10 #7945

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

kozlovsky
Copy link
Contributor

This PR fixes #7728 by closing all database connections after the db_session finishes.

If we plan to release a bugfix version for the current release, it is worth to cherry-pick this fix to the current release branch as well, as some reported access violations can be caused by this problem as well.

@kozlovsky kozlovsky requested review from a team and egbertbouman and removed request for a team March 27, 2024 07:48
@kozlovsky kozlovsky force-pushed the fix/python10-access-violation branch from 1dbe9a4 to 1d4c49b Compare March 27, 2024 07:55
@kozlovsky kozlovsky requested a review from xoriole March 27, 2024 08:38
@kozlovsky kozlovsky force-pushed the fix/python10-access-violation branch from 1d4c49b to a84ba12 Compare March 27, 2024 10:28
@kozlovsky kozlovsky merged commit b7c4bd2 into Tribler:main Mar 27, 2024
19 of 20 checks passed
@kozlovsky kozlovsky deleted the fix/python10-access-violation branch March 27, 2024 10:43
kozlovsky added a commit that referenced this pull request Mar 27, 2024
…db_session to avoid access violation on Python 3.10

(cherry picked from commit a84ba12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Tribler main does not run on Python 3.10
2 participants