Fix network name is no longer available error #7889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoriole
requested review from
a team and
egbertbouman
and removed request for
a team
egbertbouman
approved these changes
Feb 7, 2024
egbertbouman
approved these changes
Feb 7, 2024
xoriole
force-pushed
the
fix/7759-socket-error
branch
from
4eb0b5e
to
0bb26ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7759
On Windows, calling self.transport.close() can raise a CancelledError. This is because the transport is still in the event loop's transport map, and the event loop will call the transport's connection_lost method, which will call self.close() again.
This time, the transport is None, so the method will return immediately.