Refactor exception parsing logic and add exclusion for specific excep… #7718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion types - Refactored the `parse_last_core_output` function to improve readability and maintainability. - Added a regular expression pattern `_re_search_exception_exclusions` to exclude specific exception types from being parsed. - Modified the `parse_last_core_output` function to skip parsing if an excluded exception type is found. This commit improves the code by making it more modular and flexible when handling exceptions.
drew2a
requested review from
a team and
xoriole
and removed request for
a team
|
Given the numerous issues like this in the release branch, which are challenging for us to manage, I'm rebasing this PR into the release branch for easier tracking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an exclusion for the exception type found in the latest core output. Specifically, it includes the word 'warning' in the list of exclusions.
parse_last_core_outputfunction to improve readability and maintainability._re_search_exception_exclusionsto exclude specific exception types from being parsed.parse_last_core_outputfunction to skip parsing if an excluded exception type is found.Fixes #7713