Fixes #7592: remove the wait_for wrapper around await site.start() when starting HTTP REST API server
#7617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
requested review from
a team and
egbertbouman
and removed request for
a team
egbertbouman
approved these changes
Oct 2, 2023
…start()` when starting HTTP REST API server
kozlovsky
force-pushed
the
fix/7592_core_crashed_error
branch
from
e68d8dd
to
bbf42c9
Compare
kozlovsky
added a commit
to kozlovsky/tribler
that referenced
this pull request
Oct 2, 2023
kozlovsky
added a commit
that referenced
this pull request
Oct 3, 2023
Clean up rest_manager.py after removing wait_for in #7617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the core issue of #7592. The
wait_forwrapper actually didn't do anything useful here and provoked theTimeoutError. The server itself should start almost immediately, especially now, as it is directly called in the current coroutine. In case it freezes on some machine, we should be able to detect it by looking at the result of the slow coroutine detector.