Fix calling await app.shutdown() in REST API tests
#7502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
requested review from
a team and
xoriole
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out, many REST API-related test fixtures have an
app.shutdown()call at the end instead ofawait app.shutdown(), and it can be the reason for many problems with test stability.In this PR, I add a
web_appfixture that provides an instance ofaiohttp.web_app.Applicationand correctly callsawait app.shutdown()at the end.The fixture is named
web_appand notappto avoid PyCharm confusion with thesphinx.testing.fixtures.appfixture it tries to use when the new fixture is namedapp.