Rename the column with a torrent's creation date from "Updated" to "Created" to avoid confusion #7340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…The column's dict_key is not changed yet to avoid accident bugs
kozlovsky
changed the title
kozlovsky
requested review from
a team,
drew2a and
xoriole
and removed request for
a team
drew2a
approved these changes
Mar 29, 2023
Could you please create a corresponding issue? Overwise there is a risk to forget. |
|
I was able to rename it from "updated" to "created" in all necessary places, it turned out to be easier than I expected :) |
kozlovsky
force-pushed
the
fix/ui_rename_updated_to_created
branch
from
22b2a58
to
3cc5800
Compare
drew2a
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the column with the torrent's creation date from "Updated" to "Created" to avoid user confusion in the UI and adds the corresponding translation to all languages.
The corresponding data item field is still named "updated" in the application code. It is not changed to avoid accidental bugs in application logic and can be renamed later.