A DB upgrade that cleans erroneous health info from the DB #7322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
force-pushed
the
fix/upgrade_clean_self_checked_health
branch
3 times, most recently
from
fce403a
to
06e8331
Compare
kozlovsky
requested review from
a team,
xoriole and
drew2a
and removed request for
a team
xoriole
reviewed
Mar 16, 2023
src/tribler/core/upgrade/upgrade.py
Outdated
| mds_path = self.state_dir / STATEDIR_DB_DIR / 'metadata.db' | ||
|
|
||
| mds = MetadataStore(mds_path, self.channels_dir, self.primary_key, disable_sync=True, | ||
| check_tables=False, db_version=13) if mds_path.exists() else None |
There was a problem hiding this comment.
Should the db_version be 14 here?
There was a problem hiding this comment.
You are right, thanks! Usually this value does not affect the upgrade process, so I missed it
kozlovsky
force-pushed
the
fix/upgrade_clean_self_checked_health
branch
from
06e8331
to
51c111e
Compare
drew2a
suggested changes
Mar 16, 2023
kozlovsky
force-pushed
the
fix/upgrade_clean_self_checked_health
branch
3 times, most recently
from
b6ba516
to
58fa675
Compare
drew2a
approved these changes
Mar 16, 2023
kozlovsky
force-pushed
the
fix/upgrade_clean_self_checked_health
branch
from
58fa675
to
d7d8eea
Compare
Merged
kozlovsky
force-pushed
the
fix/upgrade_clean_self_checked_health
branch
from
d7d8eea
to
88ad1f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This DB upgrade finishes #7295 by cleaning incorrect records from the DB