FTS speedup #7259
Merged
FTS speedup #7259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
requested review from
a team and
xoriole
and removed request for
a team
xoriole
approved these changes
Jan 13, 2023
kozlovsky
force-pushed
the
fts_speedup
branch
2 times, most recently
from
abe2279
to
a1693f3
Compare
drew2a
approved these changes
Jan 16, 2023
kozlovsky
force-pushed
the
fts_speedup
branch
from
a1693f3
to
4a023cc
Compare
kozlovsky
force-pushed
the
fts_speedup
branch
from
4a023cc
to
6abf27f
Compare
drew2a
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a trailing
*symbol from the FTS queries.The last search word is treated as a prefix with a trailing star symbol. Due to this, queries like "1" can look up all words starting with this prefix (numbers in this example). As a result, the query can attempt to fetch many millions of rows from the database, and fetching and ordering all those rows can take a very long time. The query result, in that case, can include a large number of irrelevant results.
Removing the trailing
*symbol produces higher-quality search results and speeds up some queries up to two orders of magnitude. Without trailing*symbols, non-exact matches are still included in the query result, as the FTS query performs stemming.