Fix Windows GUI tests #7141
Merged
Fix Windows GUI tests #7141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
requested review from
a team and
kozlovsky
and removed request for
a team
kozlovsky
approved these changes
Nov 3, 2022
drew2a
force-pushed
the
fix/7132
branch
2 times, most recently
from
c9e178d
to
3504723
Compare
drew2a
commented
Nov 3, 2022
| @@ -14,7 +14,7 @@ on: | |||
| required: false | |||
|
|
|||
| enable-profiling: | |||
| default: true | |||
| default: false | |||
There was a problem hiding this comment.
I suppose that the problem is solved, and that is why profiling for GUI tests has been disabled.
drew2a
commented
Nov 3, 2022
Comment on lines
+28
to
+30
| defaults: | ||
| run: | ||
| shell: bash |
There was a problem hiding this comment.
This is the fix for Windows GUI tests.
Without it, the wrong env had been used and this led to the execution of the whole test suite.
drew2a
commented
Nov 3, 2022
| @@ -8,7 +8,7 @@ def pytest_addoption(parser): | |||
|
|
|||
| def pytest_collection_modifyitems(config, items): | |||
| for item in items: | |||
| item.add_marker(pytest.mark.timeout(30)) | |||
| item.add_marker(pytest.mark.timeout(60)) | |||
There was a problem hiding this comment.
This is the fix that should solve the timeout problem.
kozlovsky
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7132
Refs: