Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inhibit new version nag if postpone is pressed #7102

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Inhibit new version nag if postpone is pressed #7102

merged 1 commit into from
Oct 21, 2022

Conversation

vi
Copy link
Contributor

@vi vi commented Oct 21, 2022

Inhibit showing new version notification for current GUI session after postpone button is clicked.

Resolves #7077

--

Not tried running it.

@vi vi requested review from a team and drew2a and removed request for a team October 21, 2022 13:11
@tribler-ci
Copy link
Contributor

Can one of the admins verify this patch?

@vi vi mentioned this pull request Oct 21, 2022
Merged
@vi
Copy link
Contributor Author

vi commented Oct 21, 2022 •
edited
Loading

Note: competing pull request that also includes some refactoring: #7101.

@vi
Inhibit new version nag if postpone is pressed
1d7889a 
Inhibit showing new version notification for current GUI
session after postpone button is clicked.

Resolves Tribler#7077
drew2a
drew2a approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@drew2a drew2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vi, thank you for the contribution!

We'd love to see your fixes for other Tribler bugs (just make sure no one on the team hasn't assigned this issue to themselves).

@drew2a drew2a merged commit b396010 into Tribler:main Oct 21, 2022
@synctext
Copy link
Member

@vi, thank you for submitting your fixes 🏅
You are the first to submit non-trivial code changes to Tribler in years!
If you're ever near Amsterdam/Delft feel free to drop by at our university to pick up your "Tribler Coding Medal Mug" 😄

@drew2a drew2a mentioned this pull request Dec 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drew2a drew2a drew2a approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tribler is asking to upgrade version too frequently.
4 participants
@vi @tribler-ci @synctext @drew2a