Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kill Tribler on restart mechanism #5973

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Feb 1, 2021

This PR linked with #5547 and fixes an issue with the "killing Tribler on restart" mechanism.

The problem was in keywords. They can't handle processes named "Python".

@drew2a drew2a force-pushed the fix/kill_tribler_process branch 2 times, most recently from 94a3899 to a44ff4a Compare February 1, 2021 18:27
@drew2a drew2a requested a review from xoriole February 1, 2021 19:49
ichorid
ichorid previously approved these changes Feb 2, 2021
xoriole
xoriole previously approved these changes Feb 2, 2021
@drew2a drew2a dismissed stale reviews from xoriole and ichorid via dd6498e February 2, 2021 09:47
@drew2a drew2a force-pushed the fix/kill_tribler_process branch from a44ff4a to dd6498e Compare February 2, 2021 09:47
@drew2a drew2a merged commit 72bee5c into Tribler:devel Feb 2, 2021
@drew2a drew2a deleted the fix/kill_tribler_process branch February 2, 2021 09:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants