-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/5547 #5968
Fix/5547 #5968
Conversation
Heads-up while this is still in WIP: we already have |
9782db5
to
91a6523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. There might still be some references to 8085. Can you check and confirm swagger documentation is consistent?
Kudos, SonarCloud Quality Gate passed!
|
@xoriole thank you for noticing this. All related references have been updated. |
This PR partially fixes #5547 by:
8085
to52194
QSettings
. It should decrease an overlap with other QT applicationsget_first_free_port
function to ensure that we use a free port for core-gui interactionThere is another probable root case for #5547.
If the previous attempt to run Tribler's did not kill the core process properly, then it can cause the given issue (ref @xoriole)
This particular situation will be addressed in the next PR.