Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/5547 #5968

Merged
merged 5 commits into from
Feb 4, 2021
Merged

Fix/5547 #5968

merged 5 commits into from
Feb 4, 2021

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Jan 29, 2021

This PR partially fixes #5547 by:

  1. Changing default API port number from 8085 to 52194
  2. Setting up an organization for QSettings. It should decrease an overlap with other QT applications
  3. Adding a get_first_free_port function to ensure that we use a free port for core-gui interaction

There is another probable root case for #5547.
If the previous attempt to run Tribler's did not kill the core process properly, then it can cause the given issue (ref @xoriole)
This particular situation will be addressed in the next PR.

@qstokkink
Copy link
Contributor

Heads-up while this is still in WIP: we already have tribler_core/utilities/network_utils.py to claim free ports. Reusing that in the GUI would require moving it to tribler-common, but it would avoid duplication.

@drew2a drew2a force-pushed the fix/5547 branch 4 times, most recently from 9782db5 to 91a6523 Compare February 1, 2021 12:20
@drew2a drew2a changed the title WIP Fix/5547 Fix/5547 Feb 1, 2021
@drew2a drew2a requested a review from xoriole February 2, 2021 16:46
Copy link
Contributor

@xoriole xoriole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. There might still be some references to 8085. Can you check and confirm swagger documentation is consistent?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@drew2a
Copy link
Contributor Author

drew2a commented Feb 3, 2021

@xoriole thank you for noticing this. All related references have been updated.

@drew2a drew2a merged commit b67f203 into Tribler:devel Feb 4, 2021
@drew2a drew2a deleted the fix/5547 branch February 4, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[7.5.2] OSError: [Errno 10048] error while attempting to bind on address ('127.0.0.1', 8085)
3 participants