Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add <exec_target_name>_EXE_DISABLE var for TRIBITS_ADD_EXECUTABLE() #216

Closed
bartlettroscoe opened this issue Aug 12, 2017 · 3 comments
Closed

Add <exec_target_name>_EXE_DISABLE var for TRIBITS_ADD_EXECUTABLE() #216

bartlettroscoe opened this issue Aug 12, 2017 · 3 comments
Assignees
@bartlettroscoe
Labels
component: core type: enhancement

Comments

@bartlettroscoe
Copy link
Member

bartlettroscoe commented Aug 12, 2017 •
edited
Loading

This story is to add the option <full_exec_target_name>_EXE_DISABLE for TRIBITS_ADD_EXECUTABLE() so that one can externally disable the build of a failing executable (e.g. that is used for a test). This, together with <full_test_name>_DISABLE with TRIBITS_ADD[_ADVANCED]_TEST() can then be used to surgically remove failing tests (their build and their running).

Other than the general utility of this feature, this is urgently needed to fix the CI build for Trilinos (see trilinos/Trilinos#1304 and trilinos/Trilinos#1600).
@bartlettroscoe bartlettroscoe self-assigned this Aug 12, 2017
@bartlettroscoe
Copy link
Member Author

I need to use this ASAP to fix the Trilinos CI build before I go on vacation. Therefore, I am going to hack this into the Trilinos copy of TriBITS and manually test it for this one use case and then use git format-patch and git am to pull this back over to the TriBITS repo where I will then add strong automated tests and documentation (which is most of the work for adding a feature like this).

@bartlettroscoe bartlettroscoe changed the title Add <exec_target_name>_EXEC_DISABLE var for TRIBITS_ADD_EXECUTABLE() Add <exec_target_name>_EXE_DISABLE var for TRIBITS_ADD_EXECUTABLE() Aug 12, 2017
bartlettroscoe added a commit to trilinos/Trilinos that referenced this issue Aug 12, 2017
@bartlettroscoe
Add <exec_target_name>_EXE_DISABLE to TRIBITS_ADD_EXECUTABLE() (TriBI…
3a3bde5 
…TSPub/TriBITS#216)

This is just the functionality to

This is needed urgently by Trilinos to disable a test that fails to build that
is breaking the CI build (see #1600).
@bartlettroscoe
Copy link
Member Author

I just pushed the Trilinos commit trilinos/Trilinos@3a3bde5. I will need to pull this off with git format-patch and use git am to apply it back to the TriBITS 'master' branch and then add an automated test for this and documentation.

crtrott pushed a commit to mndevec/Trilinos that referenced this issue Aug 17, 2017
@bartlettroscoe @crtrott
Add <exec_target_name>_EXE_DISABLE to TRIBITS_ADD_EXECUTABLE() (TriBI…
b031b72 
…TSPub/TriBITS#216)

This is just the functionality to

This is needed urgently by Trilinos to disable a test that fails to build that
is breaking the CI build (see trilinos#1600).
bartlettroscoe added a commit that referenced this issue Mar 7, 2018
@bartlettroscoe
Add <exec_target_name>_EXE_DISABLE to TRIBITS_ADD_EXECUTABLE() (#216)
610a601 
This is just the functionality to

This is needed urgently by Trilinos to disable a test that fails to build that
is breaking the CI build (see trilinos/Trilinos#1600).
bartlettroscoe added a commit that referenced this issue Mar 7, 2018
@bartlettroscoe
Merge branch '216-exe_disable' (#216)
b755bba
bartlettroscoe added a commit that referenced this issue Mar 7, 2018
@bartlettroscoe
Add test for <exec_target_name>_EXE_DISABLE (#216)
965427f
bartlettroscoe added a commit that referenced this issue Mar 7, 2018
@bartlettroscoe
Add documentation for <exec_target_name>_EXE_DISABLE (#216)
c1bc4b8
@bartlettroscoe
Copy link
Member Author

This is done and pushed to the 'master' branch.

Closing as complete.

bartlettroscoe added a commit to trilinos/Trilinos that referenced this issue Mar 8, 2018
@bartlettroscoe
Revert "Add <exec_target_name>_EXE_DISABLE to TRIBITS_ADD_EXECUTABLE() (
e45ac5f 
TriBITSPub/TriBITS#216)"

This reverts commit 3a3bde5.

This is being removed because it was added to TriBITS proper and will be part
of the next snapshot of TriBITS which is going to be committed in the very
next commit.
bartlettroscoe added a commit to trilinos/Trilinos that referenced this issue Mar 8, 2018
@bartlettroscoe
Merge branch 'tribits_github_snapshot' into develop
afed21c 
Addresses: TriBITSPub/TriBITS#216, #2324, #2141

Build/Test Cases Summary
Enabled Packages:
Disabled Packages: PyTrilinos,Claps,TriKota
Enabled all Packages
0) MPI_RELEASE_DEBUG_SHARED_PT => passed: passed=2564,notpassed=0 (107.48 min)
Other local commits for this build/test group: e45ac5f, e1df790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartlettroscoe bartlettroscoe

Labels
component: core type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartlettroscoe