Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve release and installation with MacOS #47

Merged
merged 2 commits into from
Dec 27, 2021

Conversation

ciiiii
Copy link
Contributor

@ciiiii ciiiii commented Dec 22, 2021

What this PR does / why we need it:

  1. Support darwin arm64(m1 Mac) release and installation.
  2. Support brew install trendyol/trendyol-tap/kink --HEAD, just for someone what to use kink build with main branch.

Which issue(s) this PR related:
Implements second task on #20

Special notes for your reviewer:
This is my first PR to Trendyol open source, so i am very open to any kind of feedback!

@developer-guy
Copy link
Member

LGTM @ciiiii, thank you so much.

@developer-guy developer-guy merged commit b8e45f5 into Trendyol:main Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants