Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection: Lines needing an item tag added to work well in English #1012

Open
Soukyuu opened this issue Sep 14, 2015 · 7 comments
Open

Collection: Lines needing an item tag added to work well in English #1012

Soukyuu opened this issue Sep 14, 2015 · 7 comments

Comments

@Soukyuu
Copy link
Contributor

Soukyuu commented Sep 14, 2015

So far, we have been working around such lines. As said by @imcgames in #991, they are in the process of changing those to be more flexible, by introducing an item tag.

Post lines that need an item tag to work well in English here. For example, this one:

ETC_20150317_003375 가 충분하지 않습니다!
ETC_20150317_003375  is not sufficient!

Ideally, we'd want it to be something like

ETC_20150317_003375 Not enough {ItemName}!
@Sunaries
Copy link
Contributor

GitHub Logo

I forgot which line this is, but this is wrong. It should say: 's Anvil. In the KR test server it currently says: of 모루 (anvil).

Skill tooltip and Equipment tooltip say: X Level - While it should be: Level X

@Soukyuu
Copy link
Contributor Author

Soukyuu commented Sep 23, 2015

ETC_20150317_001854  Level

Should be

ETC_20150317_001854  Level #{CharLevel}#

This one appears on quest level requirements:
capture

@Soukyuu
Copy link
Contributor Author

Soukyuu commented Sep 23, 2015

Another one:

ETC_20150317_001763  can equip

This one is tricky. It appears on equip descriptions like this:
capture

Ideally, it should be possible to write it as "Level 1 or higher, equipable by ". For now, it's better to just remove that part, though.

@Sunaries
Copy link
Contributor

[2 Level] should be changed to [Lv. {level}]

"Level 1 or higher", "{Class} Type Class" and "can equip" are separate from each other. There is also "{level} Level or higher" or something like that one. It would be great if it could be changed to something like this:

"Lv. 1 or higher
"Equippable by {class}"

@Soukyuu
Copy link
Contributor Author

Soukyuu commented Sep 23, 2015

I don't see the need to shorten Level to Lv. in this case.

edit: I was convinced otherwise on discord :P

@Sunaries
Copy link
Contributor

I've encountered 2 other examples.

Example 1)

GitHub Logo

'S' (key), key has been assigned to, Concentrate (skill name), in your Quick Slot. are all separate marked in italics.
It should be: Concentrate has been assigned to the S key in your quick slot.

Example 2)

GitHub Logo

폰델 (mob name), You gained confidence by defeating / You have succeeded in persuasion are separate in italics.
It should be: You have gained confidence by defeating / You have persuaded Pondell.

@Sunaries
Copy link
Contributor

Sunaries commented Oct 4, 2015

I found another example.

GitHub Logo

Context: You need to attach a sap collector to Short Tree monsters. You need to collect 50 sap. If you use the sap collector to Short Tree, the text in the above image appears.
However, if properly read, it should be: You have obtained 2 Short Tree's sap!

@imcgames

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants