Fix anatomy processing and failing tests #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm castorandpollux on the wiki/discord. I noticed that Irudad has a missing anatomy on the wiki currently. It seems to be due to a comment before the declaration of his anatomy in
Bodies.xml:<!-- NPC-specific -->. This PR checks for comment nodes under<anatomies>and skips them.Also, a few of the tests weren't passing, so I took the liberty of fixing them:
test_chargeused: geomagnetic disk now uses 100 charge instead of 400.test_displayname: Irudad's title of 'Elder' is now stored in an 'Honorifics' part that currently isn't parsed by hagadias, and which is manually overridden in qud-wiki. This change gets the test passing but I recognise it's not quite in the spirit of the test... happy to change this one.