Create mvp1-template11-multiomics-ctkp.json #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding mvp1 template to support ctkp-based treats predictions (so that we can eventually remove chembl-based templates)
karafecho
reviewed
Aug 27, 2024
There was a problem hiding this comment.
I think the allowlist needs to specify infores:service-provider-trapi. Note that there is an automat endpoint for CTKP, which would allow that service to be specifically targeted, but at the moment, there is no corresponding infores entry in the infores catalog.
|
Why can't we point directly to the multiomics-clinical-tirals kp in the allow list? I think we need to point specifically to the CTKP service - as pointing to service-provider-trapi will allow predictions to be generated form chembl-based clinical trials data that remains in the system. @gglusman can you advise on what infores to use here (and if a new service needs to be registered in the infores catalog, go ahead and do this?) |
replaced trial phase based constraint with boolean elevate_to_prediction based constraint
jdr0887
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding mvp1 template to support ctkp-based treats predictions (so that we can eventually remove chembl-based templates)