Support async ts.ui.get(elm, callback) #268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zdlm @sampi @rafalages @tstapleton
Fixes #258: Async ts.ui.get();
You can now pass a callback that will be executed
If the callback is provided,
ts.ui.get
returns nothing. If the callback is not provided, it works as usual. It could work something like this.The docs, or at least most of them, have been updated to use this fancy pattern. We should of course dedicate a whole page to explain this stuff in the Intro section somewhere and I've added the task to the Documentation project over on https://github.com/Tradeshift/tradeshift-ui/projects/4.
Also in PR: somewhere in docs, there was apparently a maximim callstack exceeded here and that seems to be correct, although not completely sure why it never happened before. This would affect the iPad breakpoint on menu navigation.