Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts.ui.Note with button is too big #237

Closed
Leonid-Yeromin opened this issue Apr 25, 2017 · 4 comments
Closed

ts.ui.Note with button is too big #237

Leonid-Yeromin opened this issue Apr 25, 2017 · 4 comments
Labels
issue: bug
Milestone
7.2.0

Comments

@Leonid-Yeromin
Copy link

Bug report

Tradeshift UI version affected

v7.1.0

screen shot 2017-04-25 at 14 54 59

Expected Behavior

Actual Behavior

Steps to reproduce

Screenshots (optional)
@wiredearp
Copy link
Contributor

wiredearp commented Apr 26, 2017 •
edited
Loading

I think I made a drive by fix for this over on my branch, whatever I was working on before I went on vacation, I guess it was the jmo/modal branch.

@wiredearp wiredearp added this to the 7.2.0 milestone Apr 26, 2017
@sampi
Copy link
Contributor

sampi commented Apr 26, 2017

@wiredearp There's no more jmo/modal branch, can you push it somewhere?
Otherwise I can do the fix, it's a simple cut & paste in the .tsml of the Note.

@wiredearp
Copy link
Contributor

wiredearp commented Apr 26, 2017 •
edited
Loading

Well. It was merged to master, then. It also appears fixed over on http://ui.tradeshift.com/#components/notes/.

@sampi
Copy link
Contributor

sampi commented Apr 27, 2017

I just realized my mistake, I'll start the release process of 7.2.0 to fix the issue.

@DocGroth DocGroth closed this as completed May 1, 2017
marinalecuts pushed a commit to marinalecuts/tradeshift-ui that referenced this issue Jun 13, 2019
@zdlm
Make the chrome expand again, when user presses the user icon (Trades…
b0d937d 
…hift#237)

* Make the chrome expand again, when user presses the user icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug
Projects
None yet
Milestone
7.2.0
Development

No branches or pull requests
4 participants
@wiredearp @sampi @Leonid-Yeromin @DocGroth