Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-56330 fixed empty seg and data class issues #66

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

adityaKumar9006
Copy link
Collaborator

No description provided.

@jatin471
Copy link
Contributor

jatin471 commented Feb 3, 2025

@adityaKumar9006 in api naming, able to create empty segments URI Patterns
Screenshot 2025-02-03 at 5 18 13 PM

@jatin471
Copy link
Contributor

jatin471 commented Feb 3, 2025

In DC Overrides in span_filter/value_patterns operator Required is true but Value should be optional field as for EXIST operator value field is not required. And please add all operators (MATCHES_REGEX/EQUALS/EXISTS) in description

				"value_patterns": {
							Type:        schema.TypeList,
							Description: "Value operator and value",
							Optional:    true,
							MaxItems:    1,
							Elem: &schema.Resource{
								Schema: map[string]*schema.Schema{
									"operator": {
										Type:        schema.TypeString,
										Description: "Value operator  (MATCHES_REGEX/EQUALS)",
										Required:    true,
									},
									"value": {
										Type:     schema.TypeString,
										**Required: true,**
									},
								},
							},
						}
						

@jatin471 jatin471 merged commit 29575af into main Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants