Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(step-form-component): handle reactivity for selected column #2261

Merged

Conversation

alice-sevin
Copy link
Contributor

@alice-sevin alice-sevin commented Oct 9, 2024

I missed reactivity for selected column in weaverbird data viewer migration, it results to selected column not working as expected in migrated code

Watch update state value
Key update form component (because it not watch anything, it only apply state on init based on selected column so we need a full refresh)

@alice-sevin alice-sevin self-assigned this Oct 9, 2024
Copy link
Member

@davinov davinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vu en visio

@alice-sevin alice-sevin merged commit 9359548 into master Oct 10, 2024
2 checks passed
@alice-sevin alice-sevin deleted the fix/step-form-component-selected-column-reactivity branch October 10, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants