Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): remove store dependency for step form [TCTC-9179] #2248

Merged
merged 6 commits into from
Sep 25, 2024
Merged

chore(ui): remove store dependency for step form [TCTC-9179] #2248

merged 6 commits into from
Sep 25, 2024

Conversation

alice-sevin
Copy link
Contributor

@alice-sevin alice-sevin commented Sep 23, 2024 •
edited
Loading

  1. Export some constants and getters/actions to be able to move dataviewer component to another repository
  2. Remove store dependency from stepform component to be able to use it with query builder or without it.

Now stepform can be used as a dumb component using props or plug to store

@alice-sevin alice-sevin self-assigned this Sep 23, 2024
@alice-sevin alice-sevin changed the title chore(ui): export necessary constant and store actions to migrate data viewer [TCTC-9179] chore(ui): remove store dependency for step form [TCTC-9179] Sep 25, 2024
@alice-sevin alice-sevin force-pushed the f/export-migration branch 2 times, most recently from 3b10b95 to dd9233d Compare September 25, 2024 08:38
davinov
davinov approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@davinov davinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I've not read in details all the modifications to each step form, but the API of the StepForm component is clear. Thanks for this work 👏

ui/src/components/stepforms/StepFormComponent.vue Outdated Show resolved Hide resolved
ui/stories/StepForm.stories.ts Outdated Show resolved Hide resolved
ui/src/main.ts Show resolved Hide resolved
@alice-sevin alice-sevin merged commit 98ffc32 into master Sep 25, 2024
2 checks passed
@alice-sevin alice-sevin deleted the f/export-migration branch September 25, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinov davinov davinov approved these changes

Assignees

@alice-sevin alice-sevin

Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alice-sevin @davinov