Improve Gerrit connector usability #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains a fix that allows Gerrit HTTP password usage. See uwolfer/gerrit-rest-java-client#70
This makes it possible to use http password token that is defined in Settings -> HTTP Password page instead of the regular site password. https://gerrit-review.googlesource.com/Documentation/rest-api.html#authentication
When a cherry-pick is done and there are more commits with the same changeId, an exended id can be used to distinguish between them. It has a tilde separated format: project/subproject~branch/subbranch~changeId If this is not encoded but just put in the URL, an error message comes from the server like: Request not successful. Message: Not Found. Status-Code: 404. Content: Not found: project
As it's a Gerrit feature and not a client side deduplication, it should not have a large overhead, therefore it's enabled by default.
corebonts
force-pushed
the
108-omitduplicates
branch
from
761b4fa to
873547a
Compare
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
============================================
+ Coverage 73.25% 75.05% +1.79%
- Complexity 612 629 +17
============================================
Files 146 147 +1
Lines 1963 1984 +21
Branches 128 128
============================================
+ Hits 1438 1489 +51
+ Misses 468 436 -32
- Partials 57 59 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
============================================
+ Coverage 72.38% 75.05% +2.66%
- Complexity 608 629 +21
============================================
Files 146 147 +1
Lines 1988 1984 -4
Branches 131 128 -3
============================================
+ Hits 1439 1489 +50
+ Misses 489 436 -53
+ Partials 60 59 -1
Continue to review full report at Codecov.
|
|
I will do the merge again as gerrit lib was upgraded on master. |
|
Recreated: #230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although these fixes might work on their own, they touch the same file, that's why I created one pull request for all of them.