Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1806] Add cancel request dto (instead of plain text comment) #7562

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

[NU-1806] Add cancel request dto (instead of plain text comment) #7562

wants to merge 3 commits into from
+107 −35

Conversation

gskrobisz
Copy link
Member

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@gskrobisz gskrobisz force-pushed the add_cancel_request_body branch from 9733c80 to 2dc7c9e Compare February 12, 2025 16:11
@github-actions github-actions bot added the docs label Feb 12, 2025
@gskrobisz gskrobisz force-pushed the add_cancel_request_body branch from 2dc7c9e to 5c4dc3a Compare February 12, 2025 16:16
mateuszkp96
mateuszkp96 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@mateuszkp96 mateuszkp96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

designer/server/src/main/scala/pl/touk/nussknacker/ui/api/ManagementResources.scala Outdated Show resolved Hide resolved
@gskrobisz gskrobisz mentioned this pull request Feb 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszkp96 mateuszkp96 mateuszkp96 approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gskrobisz @mateuszkp96