Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework widgets to better support iOS 18 #1192

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Rework widgets to better support iOS 18 #1192

merged 2 commits into from
Oct 2, 2024

Conversation

GianniCarlo
Copy link
Collaborator

Purpose

  • On iOS 18 you can switch between widgets sizes for the same type. In this PR I reworked the recent books widget to fall into the same family as the last played, and also brought the play/pause toggle to the individual icons
  • I reworked the widgets to pull the data from the shared UserDefaults instead of attempting to load the CoreData database, which registered some crashes on Sentry (possibly being the source of the reports of widgets not working)

Screenshots

@GianniCarlo GianniCarlo self-assigned this Oct 1, 2024
@GianniCarlo GianniCarlo merged commit 80dc100 into develop Oct 2, 2024
1 check passed
@GianniCarlo GianniCarlo deleted the fix-widgets branch October 2, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GianniCarlo GianniCarlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GianniCarlo