Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gvanhoy fix filter length #84

Merged
merged 2 commits into from
May 2, 2023
Merged

Gvanhoy fix filter length #84

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae4465e
Fix estimate_filter_length
gvanhoy May 2, 2023
533fbe5
Fixing estimate_filter_length
gvanhoy May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions torchsig/datasets/synthetic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,9 +377,9 @@ def _generate_samples(self, item: Tuple) -> np.ndarray:
zero_padded[:: self.iq_samples_per_symbol] = symbols

# estimate total filter length for pulse shape
AdB = 72 # sidelobe attenuation level, 72 dB -> 12 bit dynamic range
attenuation_db = 72 # sidelobe attenuation level, 72 dB -> 12 bit dynamic range
pulse_shape_filter_length = DigitalModulationDataset.estimate_filter_length(
AdB, 1, signal_description.excess_bandwidth
attenuation_db, 1, signal_description.excess_bandwidth
)
pulse_shape_filter_span = int(
(pulse_shape_filter_length - 1) / 2
Expand Down