Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several imports and typing annotations #5

Merged
merged 3 commits into from
Oct 1, 2022

Conversation

dicta
Copy link
Contributor

@dicta dicta commented Sep 28, 2022

This is a set of minor fixes all relating to typing annotations not matching the actual types in use by the library.

The one new piece of code here is to add return type annotations to the functions in torchsig.transforms.functional, allowing transforms which use them to be checked. This is slightly more complex than other annotations, since the return types are partially applied functions, and these partials themselves have optional arguments with default values -- so they can't be directly represented as a Callable[[Arg1, Arg2, ...], Return]-style annotation.

@TorchDSP TorchDSP merged commit 90daaa8 into TorchDSP:main Oct 1, 2022
ereoh pushed a commit that referenced this pull request Sep 25, 2024
* Add missing import

* Add typing annotations to RNG partial functions

* Fix several incorrect typing annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants