Fix several imports and typing annotations #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereoh
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Add missing import * Add typing annotations to RNG partial functions * Fix several incorrect typing annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of minor fixes all relating to typing annotations not matching the actual types in use by the library.
The one new piece of code here is to add return type annotations to the functions in
torchsig.transforms.functional, allowing transforms which use them to be checked. This is slightly more complex than other annotations, since the return types are partially applied functions, and these partials themselves have optional arguments with default values -- so they can't be directly represented as aCallable[[Arg1, Arg2, ...], Return]-style annotation.