Fixes to root raised cosine (RRC) pulse shaping #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MattCarrickPL
commented
Mar 23, 2023
MattCarrickPL
commented
- Fixed discontinuity in impulse response at t=Ts/(4*alpha)
- Pulse shaping filter length now approximated using harris' length approximation, rather than using static value
Pull request from TorchSig main
Pull from torchsig main repo, adds sympy dependency
…off factor alpha and a sidelobe attenuation level of 72 dB (12 bit dynamic range)
Merged
|
Will do through #50 |
gvanhoy
added
wontfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.