Skip to content

Commit

Permalink
QAM/PSK Pulse shaping filter transition bandwidth corrected (#98)
Browse files Browse the repository at this point in the history
* excess bandwidth is defined in porportion to signal bandwidth, not sampling rate, thus needs to be scaled by the samples per symbol

* filling in a comment to describe modification to code
  • Loading branch information
MattCarrickPL authored May 8, 2023
1 parent 75f036b commit 0d8fbd1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion torchsig/datasets/synthetic.py
Original file line number Diff line number Diff line change
Expand Up @@ -366,8 +366,10 @@ def _generate_samples(self, item: Tuple) -> np.ndarray:
(self.iq_samples_per_symbol * len(symbols),), dtype=np.complex64
)
zero_padded[:: self.iq_samples_per_symbol] = symbols
# excess bandwidth is defined in porportion to signal bandwidth, not sampling rate,
# thus needs to be scaled by the samples per symbol
pulse_shape_filter_length = estimate_filter_length(
signal_description.excess_bandwidth
signal_description.excess_bandwidth/self.iq_samples_per_symbol
)
pulse_shape_filter_span = int(
(pulse_shape_filter_length - 1) / 2
Expand Down

0 comments on commit 0d8fbd1

Please sign in to comment.