-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and improve docker build action #151
Conversation
Compile src docker
NP, these things are hard to try out without repo access... |
Thanks @HolgerKnublauch it's working properly now! 🥳 but the "package" (docker image) is private which means only TopQuadrant members can download it. If this is OK for your organization, someone may fix it by changing the organization setting for package visibility (see screenshot below, Public should be ticked). |
Update: Apparently this can also be done at the repository level: Screencast.from.03-03-2023.12_27_28.PM.webm |
I am getting "Setting is disabled by organization administrators." Almost all TopQuadrant projects are private and commercial source code, so you will understand that I cannot risk fiddling with the settings if this exposes us even to the slightest risk. |
No worries I understand, thanks a lot anyway! |
Sure. |
Dear Holger,
Our previous PR (#149) had an issue with the GitHub action publishing docker images. We were fetching the binaries from maven at build time and mishandled version names. This PR fixes this and improves the action in the following ways:
mvn
.ghcr.io/topquadrant/shacl:1.4.3
will be created.e.g. ghcr.io/topquadrant/shacl:1.4.3_b8f215a
will be created. (whereb8f215a
is the commit sha)I apologize for the additional PR, it should work as expected now (the first action will be triggered by the merge commit).
Have an excellent week-end!