implement

Tonny-Gu · Dec 19, 2021 · 47701b5 · 47701b5
1 parent e45b60a
commit 47701b5
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 16 deletions.
diff --git a/include/mnm/communicator.h b/include/mnm/communicator.h
@@ -51,8 +51,6 @@ class Communicator {
   virtual void* GetCommHandle() = 0;
 
  protected:
-  virtual void Init() = 0;
-  virtual void Finalize() = 0;
   void GetConnector(const std::string& name = "mpi") {
     connector_.reset(ConnectorManager::Get()->GetConnector(name));
   }

diff --git a/src/distributed/common/void_communicator.cc b/src/distributed/common/void_communicator.cc
@@ -13,12 +13,6 @@ namespace communicator {
 class VoidCommunicator : public Communicator {
  public:
   VoidCommunicator() {
-    Init();
-  }
-  virtual ~VoidCommunicator() {
-    Finalize();
-  }
-  virtual void Init() {
     // In this method, you should
     // 1. Get a connector by calling GetConnector()
     // 2. Create a new communicator and store its handle.
@@ -28,7 +22,7 @@ class VoidCommunicator : public Communicator {
     LOG(INFO) << "You have created a VoidCommunicator, which will do nothing and can not be used "
                  "for parallel training.";
   }
-  virtual void Finalize() {
+  virtual ~VoidCommunicator() {
   }
   virtual void* GetCommHandle() {
     return void_comm_handle;

diff --git a/src/distributed/cuda/nccl_communicator.cc b/src/distributed/cuda/nccl_communicator.cc
@@ -23,12 +23,6 @@ namespace communicator {
 class NCCLCommunicator : public Communicator {
  public:
   NCCLCommunicator() {
-    Init();
-  }
-  virtual ~NCCLCommunicator() {
-    Finalize();
-  }
-  virtual void Init() {
     GetConnector();
     cudaSetDevice(GetLocalRank());
     if (IsRoot()) {
@@ -37,7 +31,7 @@ class NCCLCommunicator : public Communicator {
     connector_->Broadcast(reinterpret_cast<void*>(&nccl_id), sizeof(nccl_id), root_rank);
     NCCL_CALL(ncclCommInitRank(&nccl_comm, GetSize(), nccl_id, GetRank()));
   }
-  virtual void Finalize() {
+  virtual ~NCCLCommunicator() {
     NCCL_CALL(ncclCommDestroy(nccl_comm));
   }
   virtual void* GetCommHandle() {