Allow specifying commands as flags #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd take a naive approach to this issue. Ideally, we want to strive for a user to consume snag with a I'd say if you specify the flags, you can not ignore any files in the directory and the |
Tonkpils
force-pushed
the
commander
branch
3 times, most recently
from
c7ea07c to
b58ac26
Compare
|
|
zabawaba99
added a commit
that referenced
this pull request
Oct 11, 2015
Allow specifying commands as flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's discuss a couple of things on this PR.
Right now, it's either one or the other flags or snag file.
The issue comes when the snag file exists and flags are given. If command flags are specified the snag file won't be read. This can come off as a surprise to the user and we need to also think about adding ignores. What if the user has ignored files in the snag file but specifies commands as flags?