Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ImageData and AcquisitionData equality checks #1919

Merged
merged 10 commits into from
Sep 25, 2024

Conversation

lauramurgatroyd
Copy link
Member

@lauramurgatroyd lauramurgatroyd commented Aug 30, 2024

Description

Adds checks for dtype and geometry

Updates geometry check to check for dimension_labels

Adds unit tests

Example Usage

Changes

Testing you performed

See unit tests

Related issues/links

Closes #1882

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@lauramurgatroyd lauramurgatroyd marked this pull request as ready for review September 5, 2024 11:18
Signed-off-by: Laura Murgatroyd <60604372+lauramurgatroyd@users.noreply.github.com>
@lauramurgatroyd lauramurgatroyd merged commit 0d6b067 into master Sep 25, 2024
11 checks passed
@lauramurgatroyd lauramurgatroyd deleted the data_equality branch September 25, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageData and AcquisitionData __eq__ checks only for array equality
3 participants