-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct method of BlockOperator returns a single DataContainer if the output shape is (1,1) #1802
Direct method of BlockOperator returns a single DataContainer if the output shape is (1,1) #1802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add to the CHANGELOG
- Bugfix:
- BlockOperator that would return a BlockDataContainer of shape (1,1) now return the appropriate DataContainer. BlockDataContainer direct and adjoint methods accept DataContainer as parameter x.
Signed-off-by: Margaret Duff <43645617+MargaretDuff@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The direct method looks good but in PR #1766 the range and domain geometries also returned a regular DataContainer
if necessary. This would also be nice otherwise the range_geometry
may be different to the geometry of the object returned by direct()
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org> Signed-off-by: Margaret Duff <43645617+MargaretDuff@users.noreply.github.com>
Changes
See #1455
Testing you performed
Related issues/links
Fixes #1455
Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.
--->