Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjoint of DiagonalOperator for complex values #1582

Merged
merged 9 commits into from
Dec 21, 2023
Merged

Adjoint of DiagonalOperator for complex values #1582

merged 9 commits into from
Dec 21, 2023

Conversation

MargaretDuff
Copy link
Member

@MargaretDuff MargaretDuff commented Nov 21, 2023 •
edited
Loading

Describe your changes

Added conjugate to the multiplication in the adjoint of the diagonal operator and relevant unit tests

Describe any testing you have performed

Please add any demo scripts to CIL-Demos/misc/

Link relevant issues

Closes #1563

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License.
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@MargaretDuff MargaretDuff linked an issue Nov 21, 2023 that may be closed by this pull request
Adjoint of DiagonalOperator is wrong for complex values #1563
Closed
@MargaretDuff MargaretDuff self-assigned this Nov 21, 2023
@MargaretDuff MargaretDuff added the bug Something isn't working label Nov 22, 2023
@hrobarts
Copy link
Contributor

This looks good to me!

@MargaretDuff
Update CHANGELOG.md
6bd337d 
Signed-off-by: Margaret Duff <43645617+MargaretDuff@users.noreply.github.com>
@MargaretDuff
Copy link
Member Author

Jenkins is happy
image

@MargaretDuff MargaretDuff added Merge pending jenkins Once jenkins is happy with can be merged and removed bug Something isn't working Waiting for review labels Dec 21, 2023
@MargaretDuff MargaretDuff merged commit 505d9ad into TomographicImaging:master Dec 21, 2023
2 checks passed
@MargaretDuff MargaretDuff deleted the diagonal_adjoint_complex branch December 21, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfardell gfardell gfardell approved these changes

@hrobarts hrobarts hrobarts approved these changes

@paskino paskino Awaiting requested review from paskino

Assignees

@MargaretDuff MargaretDuff

Labels
Merge pending jenkins Once jenkins is happy with can be merged
Projects
No open projects
Work plan
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjoint of DiagonalOperator is wrong for complex values
3 participants
@MargaretDuff @hrobarts @gfardell