Merge pull request #1406 from jordan-brough/add-order-payment-inverse-of

[bbuchalter]

Add inverse_of to order.payments

Cherry picked from Solidus to fix https://www.pivotaltracker.com/story/show/134172587

Without this reverse association, an order object can have different payment objects in memory. When one version of the object is updated, the other is not, leading to unexpected behaviors.

In the case presented specifically in this story, the initial credit card payment is put in the invalid state by invalidate_old_payments when the new Apple Pay payment is created. However, without the reverse association, when the state machine advances the order from confirm to complete and begins process_payments!, the order.payments.map(&:state) shows ["checkout", "checkout"] showing the in-memory version of order.payments is stale.

Jordan fixed this and many other in-memory association problems in Solidus v1.4. We're back porting this one now because it's causing acute problems.

[bbuchalter]

Only one failure:

  1) setting locale checkout form validation messages shows translated jquery.validate error messages
     Failure/Error: expect(find(".field#b#{attr} label.error").text).to eq(text)

     Capybara::ElementNotFound:
       Unable to find css ".field#bfirstname label.error"

This was in the front end and is likely a false positive. How do we feel about merging this anyway?

[bbuchalter]

This was in the front end and is likely a false positive.

I get the error locally as well. Not a false positive.

[bbuchalter]

We could skip the frontend in our CI builds? Mark this spec as skipped? Or try and understand why it's not working. I'm inclined to skip the frontend part of the build completely.