Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small bug causing fault actions, added local dev env support #708

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

YogevBokobza
Copy link
Collaborator

@YogevBokobza YogevBokobza commented Jan 17, 2024

Description

Describe what you did and why.

Related issue (if any): fixes #issue_number_goes_here

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

Additional information

Anything else?

@YogevBokobza YogevBokobza requested a review from TomerFi as a code owner January 17, 2024 19:34
@pull-request-size pull-request-size bot added the size: m Pull request has 30 to 100 lines label Jan 17, 2024
@auto-me-bot auto-me-bot bot added the status: needs review Pull request needs a review label Jan 17, 2024
@YogevBokobza YogevBokobza mentioned this pull request Jan 17, 2024
Signed-off-by: YogevBokobza <yogevbokobza12@gmail.com>
@auto-me-bot auto-me-bot bot added status: approved Pull request is approved and removed status: needs review Pull request needs a review labels Jan 18, 2024
@TomerFi TomerFi enabled auto-merge (squash) January 18, 2024 13:43
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7563ef) 91.94% compared to head (ca32e6b) 91.94%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #708   +/-   ##
=======================================
  Coverage   91.94%   91.94%           
=======================================
  Files           1        1           
  Lines         211      211           
=======================================
  Hits          194      194           
  Misses         17       17           

@TomerFi TomerFi linked an issue Jan 18, 2024 that may be closed by this pull request
@TomerFi TomerFi merged commit bd2f90d into TomerFi:dev Jan 18, 2024
8 checks passed
@auto-me-bot auto-me-bot bot added status: merged Pull request merged and removed status: approved Pull request is approved labels Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request has 30 to 100 lines status: merged Pull request merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing on v1.2.5
2 participants