Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump alpine container to 3.14 #172

Merged
merged 2 commits into from
Aug 13, 2024
Merged

bump alpine container to 3.14 #172

merged 2 commits into from
Aug 13, 2024

Conversation

TomasTomecek
Copy link
Owner

Traceback (most recent call last):
  File "/usr/bin/sen", line 33, in <module>
    sys.exit(load_entry_point('sen==0.7.0', 'console_scripts', 'sen')())
  File "/usr/bin/sen", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/usr/lib/python3.9/importlib/metadata.py", line 86, in load
    module = import_module(match.group('module'))
  File "/usr/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/usr/lib/python3.9/site-packages/sen/cli.py", line 27, in <module>
    from sen.tui.init import Application
  File "/usr/lib/python3.9/site-packages/sen/tui/init.py", line 9, in <module>
    from sen.tui.commands.base import Commander, SameThreadPriority
  File "/usr/lib/python3.9/site-packages/sen/tui/commands/__init__.py", line 4, in <module>
    from .backend import RemoveCommand
  File "/usr/lib/python3.9/site-packages/sen/tui/commands/backend.py", line 8, in <module>
    from sen.tui.buffer import LogsBuffer, InspectBuffer, DfBuffer
  File "/usr/lib/python3.9/site-packages/sen/tui/buffer.py", line 3, in <module>
    from sen.docker_backend import DockerContainer, RootImage
  File "/usr/lib/python3.9/site-packages/sen/docker_backend.py", line 13, in <module>
    import docker
  File "/usr/lib/python3.9/site-packages/docker/__init__.py", line 2, in <module>
    from .api import APIClient
  File "/usr/lib/python3.9/site-packages/docker/api/__init__.py", line 2, in <module>
    from .client import APIClient
  File "/usr/lib/python3.9/site-packages/docker/api/client.py", line 6, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'

WIP

@soyo42
Copy link
Contributor

soyo42 commented Jul 26, 2024

Hi there,
I tried to build container based on HEAD of branch fix-container and had to change following to succeed:

  • anchor versions in requirements.txt:
 urwid==2.1.2
 docker==6.1.3
 requests==2.31.0
  • remove py3-pip from the apk del --purge line (it triggered removal of many python3 libs)

I also moved py3-pip from apk add -t build ... to the standard apk add ..., but I am not sure if it was necessary.

@TomasTomecek
Copy link
Owner Author

Hi there, I tried to build container based on HEAD of branch fix-container and had to change following to succeed:

  • anchor versions in requirements.txt:
 urwid==2.1.2
 docker==6.1.3
 requests==2.31.0
  • remove py3-pip from the apk del --purge line (it triggered removal of many python3 libs)

I also moved py3-pip from apk add -t build ... to the standard apk add ..., but I am not sure if it was necessary.

Thank you for looking into it! Checking this right now.

TomasTomecek added a commit that referenced this pull request Aug 12, 2024
Thanks @soyo42!

#172 (comment)

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Thanks @soyo42!

#172 (comment)

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@TomasTomecek
Copy link
Owner Author

Merging, will address the failure in a new PR, issue tracking here: #175

Thanks so much @soyo42 for nudging me here

@TomasTomecek TomasTomecek merged commit d15ae8b into master Aug 13, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants