Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ANSI Escapes in Docker Logs #67

Open
vifino opened this issue Feb 28, 2016 · 2 comments
Open

Handle ANSI Escapes in Docker Logs #67

vifino opened this issue Feb 28, 2016 · 2 comments
Milestone

Comments

@vifino
Copy link

vifino commented Feb 28, 2016

Sen currently does not handle ANSI Escapes in docker logs.

It neither strips them nor does it interpret them.

I would definitly like to see sen supporting ANSI Escapes and interpreting them, allowing color in docker logs to be properly shown.

@TomasTomecek
Copy link
Owner

TomasTomecek commented Feb 29, 2016

Thanks for report. I agree this is needed. (I often do docker logs instead of using sen).

I created upstream issue in the toolkit sen is using b/c I'm not sure what's the best of way of doing this.

@TomasTomecek TomasTomecek added this to the 1.0 milestone Feb 29, 2016
@TomasTomecek TomasTomecek modified the milestones: 0.3.1, 1.0 May 5, 2016
@TomasTomecek TomasTomecek modified the milestones: 0.5.0, 0.4.0 Nov 12, 2016
@TomasTomecek
Copy link
Owner

I spent some time on this and gotta say it's really complicated - ANSI escape sequences are pretty rich.

I decided to split this into two phases:

  1. clear the text from sequences, ignore all of them -- this is done
  2. keep coloring -- deferring later

@TomasTomecek TomasTomecek modified the milestones: 1.0, 0.5.0 Jan 4, 2017
TomasTomecek added a commit that referenced this issue Jan 4, 2017
Related #67

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit that referenced this issue Jan 4, 2017
Related #67

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants