Use chip size for selected commands where it makes sense #70
Conversation
TommyPROM/TommyPROM.ino
Outdated
| @@ -722,16 +728,30 @@ void loop() | |||
| break; | |||
|
|
|||
| case CMD_DUMP: | |||
| dumpBlock(start, end); | |||
| start = dumpBlock(start, start + if_unspec(end, 0xff)); | |||
There was a problem hiding this comment.
I think this should be
if_unspec(end, start+0xff)
otherwise d 100 1ff would dump from 100 to 2ff instead of 100 to 1ff
Am I reading that right?
There was a problem hiding this comment.
Yes that's right; will fix.
|
Do we want to check if |
|
Maybe not a good idea to adjust back to zero. If I want to fill from 200 to 2ff and accidentally type 2000 to 2ff it would be better that it fails instead of filling 0 to 2ff. I routinely take advantage of the fact that the Dump command does not enforce the prom size by using the default 28C code to read larger EPROMs. The documentation states that most chips can be read with with default code, so it would be good to leave that as is. It does mean that the code will happily dump 8K of data from a 2K chip. |
|
OK, I will run some more manual tests on my current branch soon. Is there anything that's a must-have before merging this PR? |
|
I can’t think of anything else. Looks good. |
|
The last commit moves The reason for this was that if you dumped a page, then computed the checksum w/o args, it would checksum from the saved |
|
Looks great! Are you ready to merge or still working on it? |
|
I'm done now: feel free to merge! (That last change was really just cosmetic.) |
See discussion.