Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ES5 build #57

Closed
czosel opened this issue May 4, 2019 · 18 comments · Fixed by #87
Closed

Add an ES5 build #57

czosel opened this issue May 4, 2019 · 18 comments · Fixed by #87
Assignees

Comments

@czosel
Copy link
Contributor

czosel commented May 4, 2019

Hi @TomFrost

I've been running into some issues with running Jexl 2.0 in older browsers that don't support ES6 yet (specifically IE 11). Many libraries are publishing transpiled (and often also bundled) code to npm. Would you be interested in providing something like that for Jexl as well?

I might be able to open a PR for this, but I figured I'd ask first if you're interested at all 😉

@akshaygolash
Copy link

@czosel - I am facing the same issue here, are you planning to create a PR?

@czosel
Copy link
Contributor Author

czosel commented Apr 28, 2020

Hi @akshaygolash - I'm not planning on creating a PR for this right now, because I solved the issue differently already. As you can see, this issue is already quite old. I think I'm gonna go ahead and create a issue that asks directly if @TomFrost would accept help with the maintenance of this library - I think Jexl is a great library and it would be a pity if simple things like this issue stop people from using it.

Edit: Done, see #82

@akshaygolash
Copy link

@czosel - I agree with you 100%, Thanks for replying. Do you mind to share the approach you used to fix the issue?

The issue for my project is I am using Angular 9, and angular CLI expects all libraries to provide es5 build, and hence it is breaking in IE 11.

Any help is appreciated!

@czosel
Copy link
Contributor Author

czosel commented Apr 28, 2020

We're using Jexl with Ember.js, and the issue was fixed in the framework itself (ember-auto-import transpiles dependencies automatically, embroider-build/ember-auto-import#41). Sorry I can't be of more help 😉

@akshaygolash
Copy link

Oh, I see, Thank you for your input. Much appreciated.

@akshaygolash
Copy link

Thanks @TomFrost for your prompt response, Any idea what's the ETA for this enhancement?
And thanks again for this awesome package!

@TomFrost
Copy link
Owner

TomFrost commented May 4, 2020

Hi @akshaygolash! No promises, but I'm hoping to cut a release this week. If all goes well, I'll have this in it.

@akshaygolash
Copy link

Awesome, thanks! Much appreciated.

@malka-ch
Copy link

malka-ch commented Jun 7, 2020

Any updates?

@chaitanya-pagadala
Copy link

chaitanya-pagadala commented Jun 10, 2020

Hi @TomFrost .

First of all, Thank you for the awesome library.

We have recently updated to version 2.2 and our application will not run on older browsers that do not support es2015.

Can you please let me know if we can expect a fix for this in the near future.

czosel added a commit to czosel/Jexl that referenced this issue Jun 10, 2020
czosel added a commit to czosel/Jexl that referenced this issue Jun 10, 2020
czosel added a commit to czosel/Jexl that referenced this issue Jun 10, 2020
czosel added a commit to czosel/Jexl that referenced this issue Jun 10, 2020
@daniele-pecora
Copy link

Exactly what I need.
Would like to see the xorrespondibg pull request coming up soon 😀

@kawazoe
Copy link

kawazoe commented Jul 6, 2020

While on the subject of builds, I would love to see a more versatile module format like UMD or just plain es6 modules without the CommonJS stuff in the way. This would be great for people using WebPack and Rollup since we could get tree-shaking working with this library.

@daniele-pecora
Copy link

@TomFrost Is this already part of any release now?

@TomFrost
Copy link
Owner

Hi everyone! I've been racing to try to complete the port to Typescript, as that will have to be compiled anyway. This isn't out yet, but is being actively worked on. If my timeline drags on, I'll release with @czosel's PR to tide folks over.

@czosel
Copy link
Contributor Author

czosel commented Sep 13, 2020

Hi @TomFrost, any updates on the typescript port? Might be worth sharing even something incomplete, to allow people to contribute?

@TomFrost
Copy link
Owner

Still tinkering on the Typescript side of things-- but a release is long overdue, so many thanks to @czosel's PR to add the ES5 build! That is now released in 2.3.0.

@czosel
Copy link
Contributor Author

czosel commented Sep 15, 2020

Awesome, thanks @TomFrost! 🎉

@TomFrost
Copy link
Owner

Nonono, thank you! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants