u64 workaround #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: vezenovm <mvezenov@gmail.com>
TomAFrench
added a commit
that referenced
this pull request
Feb 2, 2023
|
Closing this as the state of the repo (and noir) has moved on in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that an error in Noir is resulting in the mishandling of bits and range constraints when solving a circuit. This bug is still in the process of being fixed but until then we can work around it by leaving our bit masks as Field when performing arithmetic upon then and then only converting them to a u64 only when it is required, such as for a bit operation.
I left this is as a draft PR as it is mostly a branch for testing changes in PR #8 and needs some better test cases before confirming that this strategy is valid. For more info about the issue blocking the padding function you can look here: (noir-lang/noir#466).