Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSM Parameter Store parameters #49

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

lazaroclapp
Copy link
Contributor

The same underlying lambda extension allows access to AWS System Manager Parameter Store parameters (see docs here), in addition to secrets. However, as far as I can tell, the current version of this crate supports only secrets and not parameters.

This PR patches in support for parameters as well, including SecureString parameters (if the kms:Decrypt permission is available).

@lazaroclapp
Copy link
Contributor Author

lazaroclapp commented Mar 8, 2024

Let me know if this is a feature that should be part of aws-parameters-and-secrets-lambda and if so if any changes are needed from our internal patch above :) (Would have opened an issue first, but we already have this implementation for our own needs. We are just proposing to upstream it).

@Tom01098
Copy link
Owner

Hi @lazaroclapp, thank you for this PR! (And sorry it took me ages to get to this, GitHub didn't notify me 😢)

I'll review this shortly and get back to you :)

@Tom01098
Copy link
Owner

Thanks again for sharing this, it's a great feature to have in this package. This repo needs a little housekeeping which I'll do separately, then I'll release this as 1.0.0 :)

I'll also add a changelog and credit you for this.

Thanks!

@Tom01098 Tom01098 merged commit 02c4f24 into Tom01098:main Mar 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants